Skip to content

Fix for PackAsToolShimRuntimeIdentifiers property in VMR builds #60503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

Fix for PackAsToolShimRuntimeIdentifiers property in VMR builds #60503

merged 1 commit into from
Feb 19, 2025

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Feb 19, 2025

Fixes the VMR issue in aspnetcore flow: dotnet/sdk#46926 (comment)

In VMR build we only have one package version, matching the TargetRid.

Otherwise we're getting these types of errors - this is in x64 build:

src\aspnetcore\src\Tools\Microsoft.dotnet-openapi\src\Microsoft.dotnet-openapi.csproj(0,0): error NU1102:
 (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.NETCore.App.Host.win-x86 with version (= 10.0.0-ci)
  - Found 1458 version(s) in dotnet8 [ Nearest version: 8.0.0-rtm.23523.3 ]
  - Found 1417 version(s) in dotnet9 [ Nearest version: 9.0.0-rtm.24516.5 ]

Copilot AI review requested due to automatic review settings February 19, 2025 19:11
Copilot AI reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/Tools/Directory.Build.targets: Language not supported

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 19, 2025
@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented Feb 19, 2025

Perhaps this is a first instance of an x64 VMR package that requires both x86 and x64 assets. Should this be supported by the build?

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented Feb 19, 2025

@wtgodbe the same 2 test legs are timing out, as in most aspnetcore PRs. My changes are not affecting them so we should be able to merge this to unblock aspnetcore flow to sdk. We could rerun until they pass, but that'd only delay the fix.

I don't have permission to merge on red.

@wtgodbe wtgodbe merged commit 5feaad5 into dotnet:main Feb 19, 2025
23 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

@mmitche mmitche Awaiting requested review from mmitche

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

10.0-preview2

Development

Successfully merging this pull request may close these issues.

3 participants

@NikolaMilosavljevic @jkoritzinsky @wtgodbe